Skip to content

capture a finding's log string before it's fixed #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Oct 6, 2021
Merged

capture a finding's log string before it's fixed #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions modulecheck-plugin/src/main/kotlin/modulecheck/gradle/task/ModuleCheckTask.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ abstract class ModuleCheckTask :
val secondsDouble = timeMillis / 1000.0

if (data.isNotEmpty()) {
logger.printFailureHeader("ModuleCheck found ${data.size} issues in $secondsDouble seconds\n")
logger.printSuccessHeader("ModuleCheck found ${data.size} issues in $secondsDouble seconds\n")
}

val unFixed = grouped
Expand All @@ -90,8 +90,12 @@ abstract class ModuleCheckTask :

logger.printHeader("\t$path")

val logStrings = mutableMapOf<Finding, String>()

val (fixed, toFix) = list.partition { finding ->

logStrings[finding] = finding.logString()

if (!autoCorrect) return@partition false

if (deleteUnused && finding is Deletable) {
Expand All @@ -102,11 +106,11 @@ abstract class ModuleCheckTask :
}

fixed.forEach { finding ->
logger.printWarning("\t\t${finding.logString()}")
logger.printWarning("\t\t${logStrings.getValue(finding)}")
}

toFix.forEach { finding ->
logger.printFailure("\t\t${finding.logString()}")
logger.printFailure("\t\t${logStrings.getValue(finding)}")
}

toFix
Expand Down