This repository was archived by the owner on Jun 6, 2025. It is now read-only.
fix(react-ui-core): fixing deps and babelrc for fresh installs #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orionstein
force-pushed
the
of/fix-test-dependencies
branch
from
cd17672 to
ff98a31
Compare
Contributor
|
I've confirmed the test runner was broken on fresh install of a machine without these changes - im guessing babel-stage-0 was a dep of a dep once upon a time and was removed at another point? Do we want to consider locking down babel/jest related dependencies? 👍 |
orionstein
force-pushed
the
of/fix-test-dependencies
branch
from
ff98a31 to
c5af888
Compare
tadjohnston
previously approved these changes
Apr 25, 2018
affects: @rentpath/react-ui-core Some dependency changes broke jest on fresh installs. This installs the missing dependency and plugin for babel to transpile and run our tests correctly
orionstein
force-pushed
the
of/fix-test-dependencies
branch
from
c5af888 to
5c438cc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @rentpath/react-ui-core
Some dependency changes broke jest on fresh installs. This installs the missing dependency and
plugin for babel to transpile and run our tests correctly