Skip to content

[bugfix] Honor the systems.partitions.sched_options.max_sacct_failures configuration option for Slurm backends#3615

Merged
vkarak merged 2 commits intoreframe-hpc:masterfrom
ekouts:bugfix/max_sacct_retries
Jan 29, 2026
Merged

[bugfix] Honor the systems.partitions.sched_options.max_sacct_failures configuration option for Slurm backends#3615
vkarak merged 2 commits intoreframe-hpc:masterfrom
ekouts:bugfix/max_sacct_retries

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jan 28, 2026

The issue was present since the original PR: #3418 .
Since the comparison was wrong, Reframe would actually crash from the first retry without any warning message.

@ekouts ekouts added this to the ReFrame 4.9.1 milestone Jan 28, 2026
@ekouts ekouts self-assigned this Jan 28, 2026
@ekouts ekouts added the bugfix label Jan 28, 2026
@ekouts ekouts requested a review from vkarak January 28, 2026 10:04
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.26%. Comparing base (26ffff0) to head (a9a90a8).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
reframe/core/schedulers/slurm.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3615      +/-   ##
==========================================
+ Coverage   91.25%   91.26%   +0.01%     
==========================================
  Files          62       62              
  Lines       13584    13584              
==========================================
+ Hits        12396    12398       +2     
+ Misses       1188     1186       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vkarak
Copy link
Contributor

vkarak commented Jan 28, 2026

@ekouts Could you add a description in the PR with the behaviour that this bug was incurring? This is for future reference and to be able to provide a more accurate description in the release notes.

@vkarak vkarak changed the title Fix bug in max_sacct_failures [bugfix] Fix bug in max_sacct_failures Jan 28, 2026
@vkarak vkarak changed the title [bugfix] Fix bug in max_sacct_failures [bugfix] Honor the systems.partitions.sched_options.max_sacct_failures for Slurm backends Jan 29, 2026
@vkarak vkarak changed the title [bugfix] Honor the systems.partitions.sched_options.max_sacct_failures for Slurm backends [bugfix] Honor the systems.partitions.sched_options.max_sacct_failures option for Slurm backends Jan 29, 2026
@vkarak vkarak changed the title [bugfix] Honor the systems.partitions.sched_options.max_sacct_failures option for Slurm backends [bugfix] Honor the systems.partitions.sched_options.max_sacct_failures configuration option for Slurm backends Jan 29, 2026
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I've updated the title to be more descriptive.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in ReFrame Backlog Jan 29, 2026
@vkarak vkarak merged commit 477bf7d into reframe-hpc:master Jan 29, 2026
38 of 39 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ReFrame Backlog Jan 29, 2026
@ekouts ekouts deleted the bugfix/max_sacct_retries branch January 30, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants