[bugfix] Honor the systems.partitions.sched_options.max_sacct_failures configuration option for Slurm backends#3615
Merged
vkarak merged 2 commits intoreframe-hpc:masterfrom Jan 29, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3615 +/- ##
==========================================
+ Coverage 91.25% 91.26% +0.01%
==========================================
Files 62 62
Lines 13584 13584
==========================================
+ Hits 12396 12398 +2
+ Misses 1188 1186 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@ekouts Could you add a description in the PR with the behaviour that this bug was incurring? This is for future reference and to be able to provide a more accurate description in the release notes. |
max_sacct_failuresmax_sacct_failures
max_sacct_failuressystems.partitions.sched_options.max_sacct_failures for Slurm backends
systems.partitions.sched_options.max_sacct_failures for Slurm backendssystems.partitions.sched_options.max_sacct_failures option for Slurm backends
systems.partitions.sched_options.max_sacct_failures option for Slurm backendssystems.partitions.sched_options.max_sacct_failures configuration option for Slurm backends
vkarak
approved these changes
Jan 29, 2026
Contributor
vkarak
left a comment
There was a problem hiding this comment.
Lgtm, I've updated the title to be more descriptive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was present since the original PR: #3418 .
Since the comparison was wrong, Reframe would actually crash from the first retry without any warning message.