Skip to content

[testlib] Fix ROCm build#3574

Merged
vkarak merged 1 commit intoreframe-hpc:developfrom
cedricjourdain:fix-build-rocm6
Oct 27, 2025
Merged

[testlib] Fix ROCm build#3574
vkarak merged 1 commit intoreframe-hpc:developfrom
cedricjourdain:fix-build-rocm6

Conversation

@cedricjourdain
Copy link

@cedricjourdain cedricjourdain commented Oct 21, 2025

This PR addresses minor build and type consistency issues in gpu microbenchmarksrelated these are related to the "new" hierarchy of ROCm folder:

  • Added -I${ROCM_ROOT}/include/rocblas/ in HIP Makefiles to ensure rocblas.h is properly found.
  • Linked with -lpthread to prevent potential linkage errors.
  • Defined ROCM_ROOT?=/opt/rocm/ for consistent default paths across builds.
  • Fixed numa_node type in smi.hpp from uint32_t to int32_t to match rsmi_topo_numa_affinity_get() API expectations.

Compilation validated with ROCm 6.x on MI250 AMD GPUs

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vkarak vkarak changed the title Fix build rocm6 [testlib] Fix ROCm build Oct 25, 2025
@vkarak vkarak enabled auto-merge October 25, 2025 01:26
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (a71c68b) to head (b663a61).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3574      +/-   ##
===========================================
- Coverage    91.26%   91.25%   -0.02%     
===========================================
  Files           62       62              
  Lines        13534    13534              
===========================================
- Hits         12352    12350       -2     
- Misses        1182     1184       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vkarak vkarak merged commit 6faf9c7 into reframe-hpc:develop Oct 27, 2025
38 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants