[feat] Facilitate local imports from configuration files#3548
Merged
vkarak merged 5 commits intoreframe-hpc:developfrom Sep 18, 2025
Merged
[feat] Facilitate local imports from configuration files#3548vkarak merged 5 commits intoreframe-hpc:developfrom
vkarak merged 5 commits intoreframe-hpc:developfrom
Conversation
688ebfd to
5caf3a1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3548 +/- ##
===========================================
- Coverage 91.23% 91.22% -0.02%
===========================================
Files 62 62
Lines 13464 13470 +6
===========================================
+ Hits 12284 12288 +4
- Misses 1180 1182 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
teojgo
requested changes
Sep 16, 2025
teojgo
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the exact equivalent of loading test library module from a test file. Now users can import custom modules that reside in the same directory as the configuration file, without having to resort to boilerplate code that updates
sys.path.Close #2877.
Implementation details
Since the functionality is exactly the same as that for the test files, the code is refactored so as to be reused i both scenarios.
Note that the interface
import_module_from_file()has changed, however we sill schedule this change for 4.9, since our versioning reflects the test API and not the API of the various utilities.Todos