[enhancement] Print the performance reference tuple while running only if defined#3517
Merged
vkarak merged 2 commits intoreframe-hpc:developfrom Nov 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3517 +/- ##
========================================
Coverage 91.26% 91.26%
========================================
Files 62 62
Lines 13581 13583 +2
========================================
+ Hits 12395 12397 +2
Misses 1186 1186 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vkarak
requested changes
Jul 18, 2025
…re all defined Signed-off-by: Jack Morrison <jack.morrison@cornelisnetworks.com>
ba9a711 to
b34fab8
Compare
vkarak
reviewed
Nov 11, 2025
vkarak
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to change
A test without reference values prints
(r:0, l:None, u:None)for each performance variable. This is #3175.After change
A test without reference values does not print the reference tuple. Only the captured performance metric is printed.
A test with reference values behaves as before. The captured performance metric and its references are both printed.
Closes #3175