[feat] Enable launchers to forward environment variables#3464
Merged
vkarak merged 3 commits intoreframe-hpc:developfrom May 6, 2025
Merged
[feat] Enable launchers to forward environment variables#3464vkarak merged 3 commits intoreframe-hpc:developfrom
vkarak merged 3 commits intoreframe-hpc:developfrom
Conversation
jack-morrison
force-pushed
the
jackm/launcher-fwd-env-vars
branch
from
ab34480 to
ee90103
Compare
jack-morrison
force-pushed
the
jackm/launcher-fwd-env-vars
branch
from
ee90103 to
64f940d
Compare
vkarak
requested changes
Apr 28, 2025
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Mostly style comments. We would also need to update the general docs about launchers here:
reframe/docs/config_reference.rst
Line 495 in cb4a2ac
Where we need to add the new launchers.
Member
Author
|
I believe I've addressed all review comments via 4166dcf, but still need to manually retest the launcher behaviors with this commit. |
vkarak
requested changes
Apr 30, 2025
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
We still need to add the new launchers in the configuration docs.
Support for environment variable forwarding is added to the srun launcher, as well as two new launchers (mpirun-openmpi, mpirun-intelmpi). Signed-off-by: Jack Morrison <jack.morrison@cornelisnetworks.com>
Signed-off-by: Jack Morrison <jack.morrison@cornelisnetworks.com>
vkarak
force-pushed
the
jackm/launcher-fwd-env-vars
branch
from
4166dcf to
995a9e7
Compare
vkarak
approved these changes
May 6, 2025
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I did the remaining small changes and rebased the PR. Lgtm now. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for environment variable forwarding is added to the
srunlauncher, as well as two new launchersmpirun-openmpiandmpirun-intelmpi.Closes #3207.
References:
srun --export-genvmpirun -x