[feat] Support reference values of zero#3434
Merged
vkarak merged 2 commits intoreframe-hpc:developfrom Mar 24, 2025
Merged
Conversation
when reference value is 0 Signed-off-by: Jack Morrison <jack.morrison@cornelisnetworks.com>
vkarak
requested changes
Mar 20, 2025
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Only docs are missing, which you can add here:
reframe/reframe/core/pipeline.py
Line 726 in 20fed5d
Signed-off-by: Jack Morrison <jack.morrison@cornelisnetworks.com>
jack-morrison
force-pushed
the
jackm/2857
branch
from
666b23a to
6067bc8
Compare
vkarak
approved these changes
Mar 24, 2025
vkarak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #2857.
The spirit of #2857 is for fully supporting both relative and absolute value reference thresholds. That's not what's provided here. Rather, this PR specifically supports the case for reference values of 0. When a reference value of 0 is provided, lower and upper thresholds are treated as absolute values.