[bugfix] Disallow command options from execution modes#3432
Merged
vkarak merged 2 commits intoreframe-hpc:developfrom Apr 1, 2025
Merged
[bugfix] Disallow command options from execution modes#3432vkarak merged 2 commits intoreframe-hpc:developfrom
vkarak merged 2 commits intoreframe-hpc:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Execution modes are not allowed to use command/action options. This was never the intent of execution modes and since 4.7, since
--modeis not a command option, it was required to pass one in the command line. If the mode had already a command option, then which of the two would take effect was implementation defined. This PR disallows completely the use of command options in execution modes to avoid such abmiguities.Closes #3424.