Skip to content

Display icon in metadata #7078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Sep 8, 2023
Merged

Display icon in metadata #7078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
706e70a
Display metadata icon
feloy Sep 8, 2023
54a7cc4
UI static files
feloy Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apiserver-impl/ui/index.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pkg/apiserver-impl/ui/main.d468134bf8c5f727.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion pkg/apiserver-impl/ui/main.d81b67faa7ca223c.js
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions ui/src/app/forms/metadata/metadata.component.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
.main { padding: 16px; }
mat-form-field.full-width { width: 100%; }
mat-form-field.mid-width { width: 50%; }
.quart-width { width: 25%; }
.icon-display { display: inline-flex; position: relative; left: 16px; top: 22px; }
.width-10 { width: 10%; }
.width-40 { width: 40%; }
5 changes: 4 additions & 1 deletion ui/src/app/forms/metadata/metadata.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@
<mat-label>Icon</mat-label>
<input placeholder="Can be a URI or a relative path in the project" matInput formControlName="icon">
</mat-form-field>
<span class="icon-display width-10">
<img width="56" [src]="form.controls['icon'].value">
</span>

<mat-form-field appearance="outline" class="mid-width">
<mat-form-field appearance="outline" class="width-40">
<mat-label>Global Memory Limit</mat-label>
<input placeholder="Informative limit of memory used by the devfile. Ex: 1Gi" matInput formControlName="globalMemoryLimit">
</mat-form-field>
Expand Down