Skip to content

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Aug 21, 2023

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #7019

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 21, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l August 21, 2023 20:21
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit aca77f3
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64e614780acc910008b85b3f

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

NoCluster Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

OpenShift Unauthenticated Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

Unit Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

Validate Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

Kubernetes Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

Windows Tests (OCP) on commit eea75e3 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

OpenShift Tests on commit eea75e3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 21, 2023

Kubernetes Docs Tests on commit 471928f finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the feature-7019/ui-complete-container-creation-main branch 2 times, most recently from 4b5e923 to c7c5d0c Compare August 22, 2023 14:19
@feloy feloy force-pushed the feature-7019/ui-complete-container-creation-main branch from c7c5d0c to ff9009f Compare August 22, 2023 14:36
@feloy feloy removed the request for review from kadel August 22, 2023 14:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy changed the title [wip] [ui] Complete container creation [ui] Complete container creation Aug 23, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 23, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 28, 2023
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder labels Aug 28, 2023
@feloy
Copy link
Contributor Author

feloy commented Aug 29, 2023

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

Details

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e59cfa8 into redhat-developer:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/Dev-UI Issues or PRs related to the odo dev Web UI, a.k.a Devfile Builder kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More parameters for Container creation

3 participants