Fix naming and confusing example in gotchas #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! |
kennethreitz
pushed a commit
that referenced
this pull request
Apr 14, 2013
Fix naming and confusing example in gotchas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multipliers were named adders in the later examples; this was fixed.
To avoid confusion, I changed the def example on line 145 from a generator to using a list. If people were to run the example using the test code provided, it would actually output the "correct" (0 2 4...) answer, since the functions are run immediately after generation, and before the generation of the next function. However, consuming the entire generator and then running the functions shows the "misleading" (8 8 8) answer, since the value of
iis updated at that point.