Skip to content

Comments

Add EPUB a11y 1.1 Conformance Support#195

Merged
chocolatkey merged 4 commits intodevelopfrom
a11y-conformance-1.1
Feb 21, 2025
Merged

Add EPUB a11y 1.1 Conformance Support#195
chocolatkey merged 4 commits intodevelopfrom
a11y-conformance-1.1

Conversation

@chocolatkey
Copy link
Member

Also implements sorting of conformsTo values from best to worst
Closes #194

Sort conformsTo values from best to worst

type A11yProfileList []A11yProfile

func (l A11yProfileList) Sort() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this API really useful for integrators, or should we keep it internal for now? It seems we pre-sort the list during parsing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickael-menu I opted to keep it public because if users of the toolkit are crafting their own WebPub manifest from scratch (or from another source), they can use this function to take advantage of the sorting logic we already implemented to sort the array before e.g. marshalling or performing other logic, since it's only currently performed upon parsing of EPUB or WebPub. Do you think that's too obscure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, I've heard about a few organizations that would like to distribute content that they author as HTML rather than EPUB, so they could be the target for that.

@chocolatkey chocolatkey merged commit 500aa9f into develop Feb 21, 2025
4 checks passed
@chocolatkey chocolatkey deleted the a11y-conformance-1.1 branch February 21, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for EPUB Accessibility 1.1 conformance values

3 participants