feature: Update Reactive Generator for performance#94
Merged
ChrisPulman merged 4 commits intomainfrom Oct 28, 2024
Merged
Conversation
Use Code Analysis 4.6.0
Move shared functions into Core
| public static PropertyAttributeData? GetAttributeSyntax(this AttributeData attribute, CancellationToken token) | ||
| { | ||
| // Retrieve the syntax from the attribute reference. | ||
| if (attribute.ApplicationSyntaxReference?.GetSyntax(token) is not AttributeSyntax syntax) |
Contributor
There was a problem hiding this comment.
Mixing the ISymbol metadata with the Syntax should be reduced as possible, but its generally much more performance to go from the Symbol metadata to the Syntax so likely OK in this case.
glennawatson
approved these changes
Oct 28, 2024
glennawatson
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
update
Fixes #96
What is the current behavior?
Using Syntax Code generation
What is the new behavior?
Update TestHelper to use a single Generic Type to simplify usage
Add starter code to test IViewFor generator
Use Code Analysis 4.6.0
Update Reactive Generator for performance
Remove IsExternalInit
What might this PR break?
The usable generated code has not changed however the file names produced are shortened
Please check if the PR fulfills these requirements
Other information: