Improve AlsoNotify handling in ReactiveGenerator#356
Merged
ChrisPulman merged 2 commits intomainfrom Dec 24, 2025
Merged
Conversation
Refactors the logic for extracting AlsoNotify property names from [Reactive] attributes to be more robust, handling various constructor argument forms and fallback scenarios. Adds validation in test helpers to ensure generated code includes property change notifications for all AlsoNotify properties specified via nameof(). Updates test baselines to reflect improved code generation.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 42.86% 43.22% +0.35%
==========================================
Files 64 64
Lines 3583 3646 +63
Branches 404 420 +16
==========================================
+ Hits 1536 1576 +40
- Misses 1935 1950 +15
- Partials 112 120 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a check to only generate source files when a supported UI framework base type is detected, avoiding creation of empty generated files.
glennawatson
approved these changes
Dec 24, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix for [Reactive] tests
What is the current behavior?
[Reactive] Tests do not generate the correct code for comparision
What is the new behavior?
Refactors the logic for extracting AlsoNotify property names from [Reactive] attributes to be more robust, handling various constructor argument forms and fallback scenarios.
Adds validation in test helpers to ensure generated code includes property change notifications for all AlsoNotify properties specified via nameof(). Updates test baselines to reflect improved code generation.
What might this PR break?
[Reactive] Tests are extended with more reliable output
Please check if the PR fulfills these requirements
Other information: