Skip to content

Replace Locator with AppLocator and RxApp with RxSchedulers#339

Merged
ChrisPulman merged 1 commit intomainfrom
UpdateSplat
Dec 4, 2025
Merged

Replace Locator with AppLocator and RxApp with RxSchedulers#339
ChrisPulman merged 1 commit intomainfrom
UpdateSplat

Conversation

@ChrisPulman
Copy link
Member

What kind of change does this PR introduce?

update

What is the new behavior?

Updated references from Locator to AppLocator and RxApp to RxSchedulers across README, test files, and source generator code for consistency with new APIs. Removed commented PolySharp polyfill configuration from the project file.

What might this PR break?

AppLocator replaced Locator where used

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Updated references from Locator to AppLocator and RxApp to RxSchedulers across README, test files, and source generator code for consistency with new APIs. Removed commented PolySharp polyfill configuration from the project file.
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.04%. Comparing base (cbb80f6) to head (158a016).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #339   +/-   ##
=======================================
  Coverage   40.04%   40.04%           
=======================================
  Files          61       61           
  Lines        3389     3389           
  Branches      389      389           
=======================================
  Hits         1357     1357           
  Misses       1926     1926           
  Partials      106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@glennawatson glennawatson requested a review from Copilot December 4, 2025 22:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ReactiveUI API references to align with the latest naming conventions, replacing deprecated Locator with AppLocator and RxApp with RxSchedulers throughout the codebase. This ensures consistency with the modern ReactiveUI API and improves maintainability.

Key Changes:

  • Updated scheduler references in ReactiveCommand source generator from RxApp to RxSchedulers
  • Replaced Locator with AppLocator in test files and documentation examples
  • Removed commented-out PolySharp configuration from project file

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/ReactiveUI.SourceGenerators/ReactiveUI.SourceGenerators.csproj Cleaned up commented-out PolySharp polyfill configuration and whitespace
src/ReactiveUI.SourceGenerators.Roslyn/ReactiveCommand/ReactiveCommandGenerator.Execute.cs Updated scheduler constants from RxApp.MainThreadScheduler/TaskpoolScheduler to RxSchedulers.MainThreadScheduler/TaskpoolScheduler
src/ReactiveUI.SourceGenerators.Execute/TestViewWpf.cs Updated dependency injection reference from Locator.CurrentMutable to AppLocator.CurrentMutable
src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs Updated scheduler reference from RxApp.MainThreadScheduler to RxSchedulers.MainThreadScheduler
README.md Updated documentation examples to use AppLocator.Current and AppLocator.CurrentMutable instead of deprecated Locator API

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ChrisPulman ChrisPulman merged commit 9957d5c into main Dec 4, 2025
12 checks passed
@ChrisPulman ChrisPulman deleted the UpdateSplat branch December 4, 2025 22:43
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants