Replace Locator with AppLocator and RxApp with RxSchedulers#339
Replace Locator with AppLocator and RxApp with RxSchedulers#339ChrisPulman merged 1 commit intomainfrom
Conversation
Updated references from Locator to AppLocator and RxApp to RxSchedulers across README, test files, and source generator code for consistency with new APIs. Removed commented PolySharp polyfill configuration from the project file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 40.04% 40.04%
=======================================
Files 61 61
Lines 3389 3389
Branches 389 389
=======================================
Hits 1357 1357
Misses 1926 1926
Partials 106 106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates ReactiveUI API references to align with the latest naming conventions, replacing deprecated Locator with AppLocator and RxApp with RxSchedulers throughout the codebase. This ensures consistency with the modern ReactiveUI API and improves maintainability.
Key Changes:
- Updated scheduler references in ReactiveCommand source generator from
RxApptoRxSchedulers - Replaced
LocatorwithAppLocatorin test files and documentation examples - Removed commented-out PolySharp configuration from project file
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ReactiveUI.SourceGenerators/ReactiveUI.SourceGenerators.csproj | Cleaned up commented-out PolySharp polyfill configuration and whitespace |
| src/ReactiveUI.SourceGenerators.Roslyn/ReactiveCommand/ReactiveCommandGenerator.Execute.cs | Updated scheduler constants from RxApp.MainThreadScheduler/TaskpoolScheduler to RxSchedulers.MainThreadScheduler/TaskpoolScheduler |
| src/ReactiveUI.SourceGenerators.Execute/TestViewWpf.cs | Updated dependency injection reference from Locator.CurrentMutable to AppLocator.CurrentMutable |
| src/ReactiveUI.SourceGenerators.Execute/TestViewModel.cs | Updated scheduler reference from RxApp.MainThreadScheduler to RxSchedulers.MainThreadScheduler |
| README.md | Updated documentation examples to use AppLocator.Current and AppLocator.CurrentMutable instead of deprecated Locator API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
update
What is the new behavior?
Updated references from Locator to AppLocator and RxApp to RxSchedulers across README, test files, and source generator code for consistency with new APIs. Removed commented PolySharp polyfill configuration from the project file.
What might this PR break?
AppLocator replaced Locator where used
Please check if the PR fulfills these requirements
Other information: