chore: remove SyntaxFactory to improve performance and maintainability#103
Merged
glennawatson merged 2 commits intomainfrom Nov 4, 2024
Merged
chore: remove SyntaxFactory to improve performance and maintainability#103glennawatson merged 2 commits intomainfrom
glennawatson merged 2 commits intomainfrom
Conversation
glennawatson
reviewed
Nov 4, 2024
...urceGenerators/ObservableAsProperty/ObservableAsPropertyGenerator{FromObservable}.Execute.cs
Outdated
Show resolved
Hide resolved
glennawatson
approved these changes
Nov 4, 2024
glennawatson
approved these changes
Nov 4, 2024
glennawatson
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
What is the current behavior?
Using
SyntaxFactoryto generate code, resulting in poor maintainability.What is the new behavior?
Removed
SyntaxFactoryto improve performance and increase maintainability.What might this PR break?
None expected; it should produce the same base code output from the generator.
Please check if the PR fulfills these requirements
Other information
This PR involves renaming and updating files to improve code structure and maintainability. The changes are expected to enhance the performance of the source generator without affecting the base code output.
For more details, you can view the files changed.