Skip to content

Simplified regex expressions #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2023
Merged

Simplified regex expressions #157

merged 4 commits into from
Jun 28, 2023

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jun 27, 2023 •
edited
Loading

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Description

  • Clean up component regex, which can potentially increase regex performance.
  • Remove loops from component tests

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog has been updated with any significant changes, if necessary.
  • GitHub Issues which may be closed by this PR have been linked.

@Archmonger Archmonger requested a review from rmorshea June 27, 2023 23:36
@Archmonger Archmonger marked this pull request as ready for review June 27, 2023 23:37
@Archmonger Archmonger requested a review from a team as a code owner June 27, 2023 23:37
@Archmonger Archmonger merged commit 1cd6d39 into reactive-python:main Jun 28, 2023
@Archmonger Archmonger deleted the regex-cleanup branch June 28, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea