Add javascript interface with promise and demo project#1
Closed
alvarowolfx wants to merge 2 commits intoreact-native-documents:masterfrom
alvarowolfx:add-js-interface
Closed
Add javascript interface with promise and demo project#1alvarowolfx wants to merge 2 commits intoreact-native-documents:masterfrom alvarowolfx:add-js-interface
alvarowolfx wants to merge 2 commits intoreact-native-documents:masterfrom
alvarowolfx:add-js-interface
Conversation
Author
|
Any thoughts on this @Elyx0 ? We can enhance the demo project with the example that you added to the Readme. |
Collaborator
|
I don't think the demo project has its place for such a simple component here, it makes the whole thing way too big. Wrapping in Promises is only a few lines too. Closing for now. When Android implementation gets rolled in we might review this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.