[serve][revert] Revert supporting of 'root_path' parameter across uvicorn versions#62529
Open
axreldable wants to merge 2 commits intoray-project:masterfrom
Open
[serve][revert] Revert supporting of 'root_path' parameter across uvicorn versions#62529axreldable wants to merge 2 commits intoray-project:masterfrom
axreldable wants to merge 2 commits intoray-project:masterfrom
Conversation
…corn versions Signed-off-by: axreldable <aleksei.starikov.ax@gmail.com>
![gemini-code-assist[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the ASGI HTTP server implementation by removing the version-specific logic for handling root_path across different uvicorn versions. The helper functions _inject_root_path and _apply_root_path have been deleted, and start_asgi_http_server now passes the root_path directly from http_options. Additionally, the test_root_path test case in the FastAPI test suite has been removed. I have no feedback to provide as there are no review comments.
abrarsheikh
approved these changes
Apr 12, 2026
ray-gardener
bot
added
serve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change reverts the PR which is a part of Ray 2.54. I did my best to test that PR, but it apparently introduces issues.
Related issues
Reopens #55776. Relates to kuberay issue.
Additional information