[data] Sample schemas in unification#55845
Closed
iamjustinhsu wants to merge 4 commits intoray-project:masterfrom
Closed
[data] Sample schemas in unification#55845iamjustinhsu wants to merge 4 commits intoray-project:masterfrom
iamjustinhsu wants to merge 4 commits intoray-project:masterfrom
Conversation
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a sample_size parameter to schema unification functions to improve performance by limiting the number of schemas processed. The changes are applied across various parts of the codebase, using sample_size=1 for performance-sensitive intermediate steps and sample_size=None (for full unification) where a complete schema is necessary.
I've found a critical bug in the implementation that could lead to a TypeError when sample_size is None, which is a common case in the new code. I've also identified an opportunity to refactor duplicated code to improve maintainability. Please see my detailed comments.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
unification of schemas is slow. Provide a way to limit the number of schemas being sampled. When sample_size=1, unification is skipped and we just return the first non empty schema.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.