Return subcommand if its already registered#883
Open
bradgessler wants to merge 1 commit intorails:mainfrom
Open
Return subcommand if its already registered#883bradgessler wants to merge 1 commit intorails:mainfrom
bradgessler wants to merge 1 commit intorails:mainfrom
Conversation
7464231 to
5deaf29
Compare
| end | ||
|
|
||
| def subcommand(subcommand, subcommand_class) | ||
| return subcommand_classes[subcommand.to_s] if subcommands.include? subcommand.to_s |
Member
There was a problem hiding this comment.
Do we need to return the command class? It seems we only need to not register the command again. But what happens if people wants to override the subcommand to have different code? Let's say a library trying to enhance an already existing class. It seems that would break that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running Thor in a development environment on a server a code reloader, I noticed the subcommand would register duplicates like this:
This PR fixes that problem by checking to see if the command is registered already. If it is, it returns the existing subcommand.