Add support to stringify automatically the body of the request if the type of it isn't a string #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelolx
changed the title
adrienpoly
reviewed
Jun 18, 2021
Contributor
adrienpoly
left a comment
adrienpoly
left a comment
There was a problem hiding this comment.
I really like this idea to make it very simple for the user to just pass an object and it works.
One little comment for an alternative implementation that could be more inline with the current code style
… type of it isn't a string This allows us the make the request sending a javascript object and then RequestJS does the job of stringify the body
excid3
reviewed
Jun 18, 2021
| ... | ||
|
|
||
| async myMethod () { | ||
| const response = await post('localhost:3000/my_endpoint', { body: { name: 'Request.JS' } }) |
Contributor
There was a problem hiding this comment.
Doesn't this need responseKind: 'json' to trigger the stringify?
Collaborator
Author
There was a problem hiding this comment.
What is required is the Content-Type to be application/json and this is the default content type in this scenario https://github.com/rails/request.js/blob/main/src/fetch_request.js#L73
Contributor
There was a problem hiding this comment.
Ah! I didn't catch json as the default content type. 👍
Haven't had any caffeine yet this morning. 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #23
This allows us the make the request sending a javascript object and then RequestJS does the job of stringify the body.
I think Request.JS can do this, since most of the packages who wrap the Fetch API do the same.