Allow use of SSL-terminating reserve proxy that doesn't set headers #47139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGINX and other SSL-terminating reverse proxies can use HTTP headers to include forwarding information. If your stack includes SSL-termination through a network load balancer, that won't happen. You can use config.assume_ssl to address that.
bdewater
reviewed
Jan 25, 2023
added 2 commits
January 25, 2023 18:20
rafaelfranca
approved these changes
Jan 25, 2023
rafaelfranca
approved these changes
Jan 25, 2023
|
This feature seems to not work or I don't understand how it works. In production I have nginx proxy to rails (puma) errors and I'm seeing theses errors with any request that's not _GET nginx is available on 80 and 443 and proxy to puma cluster on 3000 |
sampoder
pushed a commit
to hackclub/hcb
that referenced
this pull request
Mar 22, 2025
rails/rails#47139 for Hetzner load balancer, but not necessary for Heroku. Must ensure that firewall is properly configured so that clients can't directly access app servers (and must go through load balancer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGINX and other SSL-terminating reverse proxies can use HTTP headers to include forwarding information. If your stack includes SSL-termination through a network load balancer, that won't happen. You can use config.assume_ssl to address that.