CLI: Limit colors in TAP reporter to test names #1801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
force-pushed
the
tap-compliant-colors
branch
from
0f78270 to
823f7b1
Compare
mgol
approved these changes
Sep 29, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
One question / suggestion, LGTM overall. The arguments seem sensible and I have no problems with the visual changes.
Don't apply colors to the "ok 1" and "not ok 1" prefix. This has the benefit of making the test names easier to visually extract for developers. It also increases compatibility with the popular `tap-parser` package which doesn't parse TAP lines correctly otherwise, since blocks like "not ok" must start on a new line, and with the color code in front, they are technically either a continuation of the previous block, or an ignored "Anything" line between two blocks. https://github.com/tapjs/tapjs/tree/ccfea67fec/src/parser https://testanything.org/tap-version-13-specification.html
Krinkle
force-pushed
the
tap-compliant-colors
branch
from
823f7b1 to
a005a0b
Compare
mgol
approved these changes
Oct 9, 2024
Krinkle
added a commit
that referenced
this pull request
Dec 4, 2024
Cherry-picked from a006064 (3.0.0-dev). > Fixes compatibility with the popular `tap-parser` > package which doesn't parse TAP lines correctly otherwise, since > blocks like "not ok" must start on a new line, and with the color > code in front, they are technically either a continuation of the > previous block, or an ignored "Anything" line between two blocks. > > https://github.com/tapjs/tapjs/tree/ccfea67fec/src/parser > > https://testanything.org/tap-version-13-specification.html > > Ref #1801. Includes a partial cherry-pick of 5812597 to clarify the local name of the onRunEnd argument as `runEnd` instead of `runSuite`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't apply colors to the "ok 1" and "not ok 1" prefix. This has the benefit of making the test names easier to visually extract for developers.
It also increases compatibility with the popular
tap-parserpackage which doesn't parse TAP lines correctly otherwise, since blocks like "not ok" must start on a new line, and with the color code in front, they are technically either a continuation of the previous block, or an ignored "Anything" line between two blocks.This hasn't been a problem in practice, since, if you pipe output from QUnit or TapReporter to a different process that uses tap-parser, colors are naturally disabled. But, if you get the console output from a browser process, the colors will be applied. I caught this while working on QTap (https://github.com/qunitjs/qtap).
https://github.com/tapjs/tapjs/tree/ccfea67fec/src/parser
https://testanything.org/tap-version-13-specification.html