Feature : added some smooth framer animation #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayur1377
requested review from
psychlone77,
saminjay and
Mathys-Gasnier
as code owners
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Great. Some suggestions:
|
Mathys-Gasnier
requested changes
Jan 1, 2025
Mathys-Gasnier
approved these changes
Jan 1, 2025
saminjay
requested changes
Jan 1, 2025
technoph1le
added
enhancement
thanks for pointing it out , fixed it! |
saminjay
requested changes
Jan 1, 2025
There was a problem hiding this comment.
Everything seems to work fine now.
Just fix all the ESLint errors introduced by you in the PR.
run npm run lint to check what those errors are.
There are many linter errors, so I think you might not have eslint configured in your editor. It would help you fix these errors.
Since you are installing a new package, we need a final confirmation from @dostonnabotov.
saminjay
approved these changes
Jan 1, 2025
psychlone77
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added some smooth animations for the code snippets , using framer here
Screen.Recording.2025-01-01.at.1.59.49.PM.mov
ps : ignore the christman theme :p
also noticed that the drop down bar is written from scratch and has too many custom css styles + too lengthy? would you like to have any fixes / improvements in that by using some standard library?