Skip to content

Conversation

Kr-Upendra
Copy link

Includes media query snippet for tailwindCSS.

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit bf7ff4c
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/6772bf6778251f0008c97095
😎 Deploy Preview https://deploy-preview-33--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't modify this file, it is auto generated by a script and a github workflow, please revert the changes you made here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon should be 50x50px, you can use tools such as resize-svg to resize it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding aria tags for accessibility; you can check the other SVG files as example.

<svg... aria-labelledby=tailwind-logo-titletailwind-logo-description">
<title id="tailwind-logo-title">Tailwind CSS Logo</title>
<desc id="tailwind-logo-description">A light blue symbol made of two parallel wavy lines, similar to a tilde</desc>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your editor generated this file, please remove it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your editor generated this file, please remove it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these snippets. I would suggest a few changes. Indicate that using min width is for a mobile first approach, and max-width is for a desktop-first approach. Also give the user some context on where to use this snippet. Like here. Give context like the file to paste it into and inside which field it should go into. Example:

// tailwind.config.js
module.exports = {
  theme: {
    screens: {
      'sm': '640px',
      'md': '768px',
      'lg': '1024px',
      'xl': '1280px',
      '2xl': '1536px',
    }
  }
}

@Kr-Upendra
Copy link
Author

made the required changes.

@Mathys-Gasnier
Copy link
Collaborator

you forgot to remove the two .tsbuildinfo files you added

@Kr-Upendra
Copy link
Author

remove auto generated files

@Kr-Upendra Kr-Upendra closed this by deleting the head repository Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants