-
-
Notifications
You must be signed in to change notification settings - Fork 130
Add some responsive breakpionts in CSS #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To create a multi platform website you need breakpoints for varius platforms. so I added Responsive design, with: phone, tablet and desktop
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the Desktop extra large
and bige
really necessary ?
It may be necessary in some cases, |
I think snippet should show the functionning of a feature, and for media queries i think just showing the user how it works (explaining that it only applies if screen size > an amount, etc) is the goal, more than giving the user a list of media queries without explaination |
That's true, |
@kruimol, thank you for the contribution. 🙌 I like the idea of adding responsive design. Regarding the breakpoints, we can move them to SCSS maps to show in an organized way. Something like this: // values needs to be updated here as well
$breakpoints: (
sm: 30em,
md: 50em,
lg: 75em,
); Add a mixin to access those breakpoints from maps with // media query
@mixin mq($key) {
$size: map-get($breakpoints, $key);
@if ($size) {
@media (width > $size) {
@content;
}
} @else {
@error '`#{$key}` does not exist in the $breakpoints';
}
} Let me know what you think. |
And, we still need breakpoints in CSS as well. Because some developers aren't familiar with SCSS yet. So, adding a code snippet for common breakpoints would help them a lot. I think I'm open to listening your approach on this one as well. |
Yes that was my intention too, I'm not that familiar with scss myself. |
To create a multi platform website you need breakpoints for varius platforms.
So I added Responsive design, with: phone, tablet and desktop