Skip to content

fix(useInterval): remove unused argument passed to removeInterval (fixes #18273)#18274

Merged
rstoenescu merged 1 commit intoquasarframework:devfrom
Kundan-CR7:fix-useInterval-remove-argument
Apr 4, 2026
Merged

fix(useInterval): remove unused argument passed to removeInterval (fixes #18273)#18274
rstoenescu merged 1 commit intoquasarframework:devfrom
Kundan-CR7:fix-useInterval-remove-argument

Conversation

@Kundan-CR7
Copy link
Copy Markdown
Contributor

Fixes #18273

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Description

In ui/src/composables/use-interval/use-interval.js, the registerInterval
function calls:

removeInterval(timer)

However, the removeInterval function does not accept any parameters and
uses the closure-scoped timer variable internally.

Passing timer as an argument has no effect and may confuse readers.

This PR removes the unnecessary argument to improve code clarity.

Before

removeInterval(timer)

After

removeInterval()

This change does not affect runtime behavior.


The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated

Other information:

This is a small internal cleanup that removes an unused argument and improves
code readability without changing functionality.

@github-actions
Copy link
Copy Markdown

UI Tests Results

    1 files     98 suites   47s ⏱️
1 031 tests 1 031 ✅ 0 💤 0 ❌
1 050 runs  1 050 ✅ 0 💤 0 ❌

Results for commit dd1022e.

@rstoenescu rstoenescu merged commit 1a06787 into quasarframework:dev Apr 4, 2026
3 checks passed
@rstoenescu
Copy link
Copy Markdown
Member

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useInterval: registerInterval passes unused argument to removeInterval

2 participants