Sync with QL 1.41 #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR syncs the qlcal R package with QuantLib version 1.41 by updating three source files and bumping the package version.
Changes:
- Updated version from 0.0.17 to 0.0.17.1 with current date
- Removed input validation checks from two calendar functions
- Modified observer pattern implementation to use map instead of set with validity tracking
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DESCRIPTION | Bumped version to 0.0.17.1 and updated date to 2026-01-13 |
| ChangeLog | Added entry documenting the sync with QuantLib 1.41 |
| src/ql/time/calendar.cpp | Removed QL_REQUIRE validation checks from holidayList and businessDayList functions |
| src/ql/patterns/observable.hpp | Changed deferredObservers_ from std::set to std::map with validity flag, added runningDeferredUpdates flag and accessor, updated unregisterDeferredObserver logic |
| src/ql/patterns/observable.cpp | Added runningDeferredUpdates flag management and validity checking in deferred observer updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.