Merged
Conversation
generall
requested changes
Nov 11, 2025
Member
generall
left a comment
generall
left a comment
There was a problem hiding this comment.
Could you please add
- Constructor/Builder for
ShardKeySelectorwhich would include fallback shard. - Constructor/Builder for
AcornSearchParams - Query constructor for Rrf option - similar to
new_formula,new_fusione.t.c - Support for
text_anysimilar tomatches_phrase
generall
reviewed
Nov 11, 2025
generall
reviewed
Nov 11, 2025
generall
reviewed
Nov 11, 2025
generall
approved these changes
Nov 12, 2025
3 tasks
timvisee
force-pushed
the
update-to-latest-dev
branch
from
d814533 to
480e364
Compare
timvisee
force-pushed
the
update-to-latest-dev
branch
from
a753e62 to
f6f6cd4
Compare
timvisee
force-pushed
the
update-to-latest-dev
branch
from
862c6a4 to
75c122b
Compare
timvisee
approved these changes
Nov 12, 2025
Member
timvisee
left a comment
timvisee
left a comment
There was a problem hiding this comment.
I think this is ready now!
Did some final work to make deprecation in docs a bit better:
timvisee
added a commit
that referenced
this pull request
Nov 12, 2025
* Update to latest dev * Address review * Mode fallback and acorn to dedicated builders * Extend tests * Move rrf to dedicated builder * Fix linters * Remove obsolete allow(unused_mut) attributes * Bump proto definitions, include initial_state and vector deprecations * Beautify deprecation warnings and links --------- Co-authored-by: timvisee <tim@visee.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update proto files and implement related changes in rust.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?