Merged
Conversation
timvisee
approved these changes
Jul 15, 2025
JojiiOfficial
approved these changes
Jul 16, 2025
| pub fn stemmer_language(self, language: String) -> Self { | ||
| let mut new = self; | ||
| let stemmer = StemmingAlgorithm { | ||
| stemming_params: Some(stemming_algorithm::StemmingParams::Snowball( |
Contributor
There was a problem hiding this comment.
We should not hard-code Snowball here. We may want to add more stemming libraries later. Hard-coding it here won't allow us to extend the client later without breaking changes.
Alternatively we can rename this function to e.g. snowball_stemmer and let users use the stemmer function for better customization.
Contributor
|
Added constructors for |
timvisee
added a commit
that referenced
this pull request
Jul 18, 2025
* update proto, generated types, and add new builders * fmt * fix doctest * BinaryQuantizationQueryEncoding variants * add snippet for creating text index * add bq snippets * rename stemmer helper function * Bump proto definitions --------- Co-authored-by: Ivan Pleshkov <pleshkov.ivan@gmail.com> Co-authored-by: generall <andrey@vasnetsov.com> Co-authored-by: timvisee <tim@visee.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates proto, generated types, and adds new builders