Conversation
Closed
JojiiOfficial
approved these changes
Jun 26, 2025
| download_snapshots = ["reqwest", "futures-util"] | ||
| serde = ["dep:serde", "dep:serde_json"] | ||
| generate-snippets = [] | ||
| uuid = ["dep:uuid"] |
Contributor
There was a problem hiding this comment.
I think this is not needed, since it's an optional dependency, this can work as feature alone.
But totally fine to keep it to keep it clean.
Member
Author
There was a problem hiding this comment.
You're right. I only put it there to clarify we have this 'option'.
agourlay
approved these changes
Jun 26, 2025
generall
pushed a commit
that referenced
this pull request
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225
Allows
PointId::from(uuid)andPointStruct::new(uuid, ...)as requested here.Because we normally don't depend on
uuidin our Rust crate, I've added it as optional dependency. Users can enable it as they please.All Submissions:
devbranch. Did you create your branch fromdev?