Derive clone on all builders for better request building#223
Merged
Conversation
JojiiOfficial
force-pushed
the
derive_clone_for_builders
branch
from
ddb8f95 to
20137aa
Compare
Member
|
You may use a similar strategy as qdrant/qdrant#6529 to please Clippy |
Contributor
Author
|
Thanks for the hint! |
agourlay
approved these changes
May 23, 2025
timvisee
approved these changes
May 27, 2025
generall
pushed a commit
that referenced
this pull request
Jul 14, 2025
* Derive clone on all builders for better request building * Make clippy happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives
Clonefor all builders.Having
Cloneon builders allows creating duplicates of builders and makes it easy to create two similar requests with almost the parameters.This comes especially handy if a request-builder has many configured attributes but a user needs to create variations of this request.