Skip to content

Include actual server error message in reporting#185

Merged
agourlay merged 1 commit intodevfrom
improve-error-reporting
Aug 29, 2024
Merged

Include actual server error message in reporting#185
agourlay merged 1 commit intodevfrom
improve-error-reporting

Conversation

@agourlay
Copy link
Member

@agourlay agourlay commented Aug 29, 2024

This PR improves the error reporting when the server returns an error to return the full error message.

This is needed because it is currently very difficult for a user to understand why a request fails without looking into the server logs.

For instance when trying to create a malformed collection the client yields:

Error in the response: Client specified an invalid argument

However the server logs say:

INFO qdrant::tonic::logging: gRPC /qdrant.Collections/Create failed with Client specified an invalid argument "Wrong input: `shard_number` cannot be 0"

With this PR the users will see the message as well.

@agourlay agourlay requested review from generall and timvisee August 29, 2024 09:47
@agourlay agourlay merged commit 9e16932 into dev Aug 29, 2024
@agourlay agourlay deleted the improve-error-reporting branch August 29, 2024 13:23
@agourlay agourlay mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants