Skip to content

Numpy-like flattening#624

Draft
argerlt wants to merge 3 commits intopyxem:developfrom
argerlt:numpy-like-flattening
Draft

Numpy-like flattening#624
argerlt wants to merge 3 commits intopyxem:developfrom
argerlt:numpy-like-flattening

Conversation

@argerlt
Copy link
Collaborator

@argerlt argerlt commented Feb 3, 2026

CUrrently unfinished, but when it's done, this This PR addresses and should close #595 once finished.

Main remaining task is to add an order parameter to all the functions that run super.flatten()

To give some scope to this problem, pytest raises 191258 warnings in htis PR. That's enough that we should probably add a filter inside Object3d.

Progress of the PR

Minimal example of the bug fix or new feature

For reviewers

  • The PR title is short, concise, and will make sense 1 year later.
  • New functions are imported in corresponding __init__.py.
  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.
  • Contributor(s) are listed correctly in __credits__ in orix/__init__.py and in
    .zenodo.json.

@argerlt argerlt marked this pull request as draft February 3, 2026 02:36
@argerlt argerlt force-pushed the numpy-like-flattening branch from 1eca65c to f1d3992 Compare February 27, 2026 22:55
@argerlt
Copy link
Collaborator Author

argerlt commented Feb 27, 2026

pre-commit.ci autofix

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Object3d.flatten() flattens in the opposite order from numpy

1 participant