PR623 Add "Phase.plot_unit_cell" function#623
Open
argerlt wants to merge 8 commits intopyxem:developfrom
Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
|
pre-commit.ci autofix |
1 similar comment
Collaborator
Author
|
pre-commit.ci autofix |
Collaborator
Author
|
@hakonanes, it looks like psf/black and pre-commit are disagreeing with each other on how to format "S2_sampling.py". My thought is to just remove the psf/black check from workflows. we can do it in the hotfix 0.14.2 hotfix if you agree. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
8682d43 to
50cff46
Compare
Collaborator
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
As part of updating the examples, I wanted to be able to plot a unit cell. It ended up being nicer to just make it a class feature as opposed to a function in an example. This does that, and replaces a large chunck of
crystal_map.ipynbwith examples.For reference, here are similar functions in other packages
py4dstem kinematical example notebook
The atomic models tutorial from abTEM
MTEX
Progress of the PR
Minimal example of the bug fix or new feature
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.