BugFix: Allow get_kwargs for setting kwargs on __mul__#499
Open
CSSFrancis wants to merge 3 commits intopyxem:developfrom
Open
BugFix: Allow get_kwargs for setting kwargs on __mul__#499CSSFrancis wants to merge 3 commits intopyxem:developfrom
CSSFrancis wants to merge 3 commits intopyxem:developfrom
Conversation
This was referenced May 7, 2024
Member
|
Thanks for suggesting a fix to the issue in diffsims. But, I've raised some doubts regarding our approach in the referenced issue pyxem/diffsims#211 (comment). |
Member
Author
|
@hakonanes I think this should be possible. It works quite nicely with everything and makes the logic much simpler. Otherwise we end up having to struggle to track the rotation alongside the RLV from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This should fix (part) of the problems upstream with pyxem/diffsims#211 by allowing the function
get_kwargsto be overwritten in subclasses and change the order/what is passed to the init fuction.Minimal example of the bug fix or new feature (This now works)
For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.