Skip to content

Ensure fps is integer before passing to av backend#8991

Merged
NicolasHug merged 2 commits intopytorch:mainfrom
HSPK:fix/write_video_fps
Mar 26, 2025
Merged

Ensure fps is integer before passing to av backend#8991
NicolasHug merged 2 commits intopytorch:mainfrom
HSPK:fix/write_video_fps

Conversation

@HSPK
Copy link
Contributor

@HSPK HSPK commented Mar 20, 2025

Related to #8990

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8991

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 20, 2025

Hi @HSPK!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

NicolasHug
NicolasHug approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HSPK

@NicolasHug NicolasHug merged commit 3ea9ed9 into pytorch:main Mar 26, 2025
1 check passed
@github-actions
Copy link

github-actions bot commented Mar 26, 2025

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug mentioned this pull request Mar 26, 2025
Closed
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
@NicolasHug @facebook-github-bot
[fbsync] Ensure fps is integer before passing to av backend (#8991)
5cd0cd2 
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: scotts

Differential Revision: D77998630

fbshipit-source-id: aaf14319bba17681efab7c0c0001ec5471890205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HSPK @facebook-github-bot @NicolasHug