split NVCC_FLAGS but not quoted string#8933
Merged
NicolasHug merged 2 commits intopytorch:mainfrom Feb 24, 2025
Merged
Conversation
In case NVCC_FLAGS contains something like --compiler-options \"-march=native -O2 -pipe\" the quoted parts needs to stay entirely (not splitted)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8933
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Reviewed By: scotts Differential Revision: D77997071 fbshipit-source-id: 628cd01948af1528fd68f902c64837a8704a42d2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case NVCC_FLAGS contains something like --compiler-options "-march=native -O2 -pipe" the quoted parts needs to stay entirely (not splitted)