Fix compile with nvjpeg on Windows CUDA 12#8641
Merged
atalman merged 3 commits intopytorch:mainfrom Sep 11, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8641
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1249d0b with merge base 00e7fa1 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
NicolasHug
approved these changes
Sep 11, 2024
|
Hey @atalman! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Reviewed By: vmoens Differential Revision: D62581682 fbshipit-source-id: 40ee1636bb1608da92b1fc258634d26c88a430fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of the issue
Hence we are seeing for cuda 12+ jobs:
As a result its failing builder checks here:
https://github.com/pytorch/builder/actions/runs/10776424717/job/29883192429
Driver Update issue should not prevent us to compile torchvision with full CUDA support. We can do it even with CPU instance. Hence when FORCE_CUDA flag is set, we should try to include nvjpeg module.
As a followup we should address Driver issue