Skip to content

Better progress bar for file downloading#8556

Merged
NicolasHug merged 2 commits intopytorch:mainfrom
mshr-h:patch-2
Jul 30, 2024
Merged

Better progress bar for file downloading#8556
NicolasHug merged 2 commits intopytorch:mainfrom
mshr-h:patch-2

Conversation

@mshr-h
Copy link
Contributor

@mshr-h mshr-h commented Jul 30, 2024

Set the unit to "B" (byte) and enable unit_scale.

Without this change:

Downloading https://www.cs.toronto.edu/~kriz/cifar-100-python.tar.gz to /data/datasets/cifar100/cifar-100-python.tar.gz
  4%|███                                                                    | 6324224/169001437 [00:04<01:03, 2581642.25it/s]

With this change:

Downloading https://www.cs.toronto.edu/~kriz/cifar-100-python.tar.gz to /data/datasets/cifar100/cifar-100-python.tar.gz
  3%|███▏                                                                  | 5.54M/169M [00:03<00:47, 3.47MB/s]

cc @NicolasHug

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8556

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 15 Unrelated Failures

As of commit 277c084 with merge base ef8c0f6 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mshr-h

@NicolasHug NicolasHug merged commit 478c670 into pytorch:main Jul 30, 2024
@mshr-h mshr-h deleted the patch-2 branch July 30, 2024 11:36
facebook-github-bot pushed a commit that referenced this pull request Aug 2, 2024
Summary: Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>

Reviewed By: vmoens

Differential Revision: D60596228

fbshipit-source-id: 22a4683f8f4ca1866811ccef4169d2e6d93215b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants