Force use of torch.compile on deterministic roi_align implementation

[ezyang]

Fixes #8168

Signed-off-by: Edward Z. Yang ezyang@meta.com

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8436

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 1 Unrelated Failure

As of commit ee25749 with merge base 775dd2d ():

NEW FAILURES - The following jobs have failed:

• CMake / macos (macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• CMake / windows (windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-macos (3.10, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.11, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.12, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.8, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-macos (3.9, macos-m1-stable) / macos-job (gh)
  The process '/usr/bin/git' failed with exit code 128
• Tests / unittests-windows (3.10, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.11, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.12, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.8, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
• Tests / unittests-windows (3.9, windows.4xlarge, cpu) / windows-job (gh)
  The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128

FLAKY - The following job failed but was likely due to flakiness present on trunk:

• Tests / unittests-linux (3.8, linux.g5.4xlarge.nvidia.gpu, cuda, 11.8) / linux-job (gh) (matched linux rule in flaky-rules.json)
  The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ezyang]

cc @qqaatw, I removed the MPS knob because of how memory hungry the eager implementation is, I doubt torch.compile works on MPS.

[NicolasHug]

Thanks @ezyang , 2 questions below but LGTM anyway. Unfortunately the MPS-related tests are all toasted (#8433), it's not related to this PR.

[NicolasHug]

Am I understanding this correctly?

Suggested change

	This avoids eagerly importing dynamo.
	This avoids eagerly compiling a function at import time.

[ezyang]

Nope. Even with torch.compile at top level it isn't compiled until you call it the first time. But importing dynamo has undesirable side effects for eager mode only users so it's best not to do it.

[NicolasHug]

Should we just remove the mps part here since you mentioned MPS doesn't even work with torch.compile?

Suggested change

	not _has_ops() or (torch.are_deterministic_algorithms_enabled() and (input.is_cuda or input.is_mps))
	not _has_ops() or (torch.are_deterministic_algorithms_enabled() and input.is_cuda)

[ezyang]

I opted to keep it around, because it was explicitly added by @qqaatw, but I don't really mind either way

[qqaatw]

Sorry for the late reply! I'm ok with either way that is best for the development. From the mentioned issue it seems only relevant to CUDA, is MPS similarly memory hungry with deterministic algorithm?