Add compatibility with FFMPEG 7.0#8408
Merged
NicolasHug merged 4 commits intopytorch:mainfrom Jun 6, 2024
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8408
Note: Links to docs will display an error until the docs builds have been completed. ❌ 16 New Failures, 12 Unrelated FailuresAs of commit d64420a with merge base a839642 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
a1f2a4b to
2312b39
Compare
channel_layout has been replaced with ch_layout
NicolasHug
approved these changes
Jun 6, 2024
Member
NicolasHug
left a comment
There was a problem hiding this comment.
Thank you @eclipseo . Our CI only compiles against ffmpeg4, all of the ffmpeg-related tests are unfortunately disabled #8162.
The compilation step of the jobs in this PR (with ffmpeg4) are running fine. I tried locally to compile and run some tests against ffmpeg7, which was successful.
Unfortunately, this is the best amount of testing we can provide for this right now...
Thanks a lot for the PR, I'll merge it now.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
Reviewed By: vmoens Differential Revision: D58283813 fbshipit-source-id: 749e5c793d27ea87e3e12e1b3ecc146a40530067 Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Miriup
pushed a commit
to Miriup/torchvision-cuda-10.2
that referenced
this pull request
Dec 9, 2024
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> (cherry picked from commit 375cfdf)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.