Skip to content

[FBcode->GH] [codemod] Use nullptr intead of NULL#8335

Merged
NicolasHug merged 2 commits intopytorch:mainfrom
NicolasHug:alfjenlajenfaef
Mar 20, 2024
Merged

[FBcode->GH] [codemod] Use nullptr intead of NULL#8335
NicolasHug merged 2 commits intopytorch:mainfrom
NicolasHug:alfjenlajenfaef

Conversation

@NicolasHug
Copy link
Member

Summary:
nullptr is preferable to 0 or NULL. Let's use it everywhere so we can enable -Wzero-as-null-pointer-constant.

  • If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: dmm-fb

Differential Revision: D54835530

fbshipit-source-id: ef118f6fdbb658b38be13076de3c1fe805251155

Summary:
`nullptr` is preferable to `0` or `NULL`. Let's use it everywhere so we can enable `-Wzero-as-null-pointer-constant`.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: dmm-fb

Differential Revision: D54835530

fbshipit-source-id: ef118f6fdbb658b38be13076de3c1fe805251155
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/8335

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures, 7 Unrelated Failures

As of commit 3e6fc2d with merge base 18a1d41 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this makes sense, lgtm, thanks!

@NicolasHug NicolasHug merged commit d868be9 into pytorch:main Mar 20, 2024
@NicolasHug NicolasHug deleted the alfjenlajenfaef branch March 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants