Enable windows arm64 builds for vision#6352
Conversation
|
@alinpahontu2912 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
Would it be possible to add a testing workflow here to validate that we don't break things whenever we make changes?
![github-advanced-security[bot]](https://waps.l3s.uni-hannover.de/live/im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Also not a huge fan of batch and the fact that 3/5 of these scripts are copy / pasted from the For now this is fine, I'm going to set a reminder for myself in 6 months (September 25, 2025) to check on this and if these aren't updated to something other than batch I'm going to recommend we remove them. |
seemethere
left a comment
seemethere
left a comment
There was a problem hiding this comment.
Going to take a bit of a harder stance on this and say that we shouldn't add new batch at all here.
I know this is inconvenient but I want to hold a higher bar for these since we should be intentional about when we decide to take things on for maintenance and we're purposefully choosing now to not maintain batch.
Please update this PR to convert the batch to either bash or python
| needs: generate-matrix | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
There was a problem hiding this comment.
Do we also want to test audio here as well?
There was a problem hiding this comment.
Does it matter which one we use in the testing workflow? I thought this worklflow is supposed to just to check if anything starts breaking, so does it make a difference if we use audio or vision?
There was a problem hiding this comment.
Well if you want to test if this works across vision and audio it might make sense to test both of them here
|
The arm64 build will fail since the new workflow depends on the changes from the torchvision repository: pytorch/vision#8947. |
|
hey @seemethere can you please re-trigger the tests? we do not have the permissions to do so. |
I retriggered them for you. |
|
Hey, @zxiiro or @seemethere can you retrigger them again? |
Done |
|
Thank you very much @zxiiro, can you try again, please? |
|
Hey @seemethere @zxiiro can you retrigger again please ? |
|
Hey @malfet @seemethere can you run the workflows again ? |
|
Hey @zxiiro, thanks lot for the very fast replies, can you rerun the tests again, please? |
No problem! |
|
Hey, @zxiiro, can you do it again? |
|
Hey @seemethere @malfet can you take a look again and merge this? |
malfet
changed the title
Add scripts and workflow for enabling windows arm64 builds
In #6352, building of wheels for win-arm64 was added. This PR aligns the naming in the workflow more closely with the rest of the workflow file and adds the more modern `python -m build` variant to the previously used direct invocation of `setup.py bdist_wheel` as is done for other platforms.
6 participants
Add scripts and workflow for enabling windows arm64 builds