Skip to content

Fix division by zero in reduce_util.h grain size calculation #16462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psiddh merged 3 commits into from
Jan 6, 2026
Merged

Fix division by zero in reduce_util.h grain size calculation #16462

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f776870
Fix circular import in cortex_m passes using relative imports
Dec 23, 2025
efc641d
Merge branch 'pytorch:main' into main
psiddh Jan 5, 2026
8186e26
Fix division by zero in reduce_util.h grain size calculation
Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions kernels/portable/cpu/util/reduce_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,10 +814,12 @@ template <typename Func>
const Func& func) {
#ifdef ET_USE_THREADPOOL
const ssize_t reduction_size = get_reduced_dim_product(in, dim);
const auto grain_size = std::max(
static_cast<ssize_t>(1),
static_cast<ssize_t>(executorch::extension::internal::GRAIN_SIZE) /
reduction_size);
const auto grain_size = reduction_size == 0
? 1
: std::max(
static_cast<ssize_t>(1),
static_cast<ssize_t>(executorch::extension::internal::GRAIN_SIZE) /
reduction_size);
#else // ET_USE_THREADPOOL
const auto grain_size = 1;
#endif // ET_USE_THREADPOOL
Expand Down
Loading