Skip to content

Conversation

@rascani
Copy link
Contributor

@rascani rascani commented Dec 23, 2025

Summary

Update three activation test configurations to avoid being classified as depthwise convolutions. Changed Conv2d(1,1,1) to Conv2d(2,1,1) with weight=0.5 in:

  • CortexMConv2DHardswish
  • CortexMConv2DHardsigmoid
  • CortexMConv2DClampInplace

Test Plan

pytest --config-file=backends/arm/test/pytest.ini \
  backends/cortex_m/test/ops/test_activation.py

Update three activation test configurations to avoid being classified
as depthwise convolutions. Changed Conv2d(1,1,1) to Conv2d(2,1,1) with
weight=0.5 in:
- CortexMConv2DHardswish
- CortexMConv2DHardsigmoid
- CortexMConv2DClampInplace

Test Plan:
```
pytest --config-file=backends/arm/test/pytest.ini \
backends/cortex_m/test/ops/test_activation.py
```
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16379

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit 7f444f8 with merge base 1ce615e (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2025
@rascani rascani requested a review from psiddh December 23, 2025 21:52
@rascani
Copy link
Contributor Author

rascani commented Dec 23, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Dec 23, 2025
@rascani rascani marked this pull request as ready for review December 23, 2025 21:59
@rascani rascani requested a review from digantdesai December 23, 2025 22:19
@rascani rascani merged commit c5d66a5 into pytorch:main Dec 24, 2025
301 of 302 checks passed
@rascani rascani deleted the fix_cortex_m branch January 15, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants