-
Notifications
You must be signed in to change notification settings - Fork 821
Cortex_m backend: Support channels-broadcasting for ADD/MUL #16131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds support for broadcasting in the special case where one input contains only channels which are broadcasted onto every spatial element of the other tensor, e.g. [1,C,1,1] + [N, C, H, W] for channel-last tensors. This is a needed for mobilenet_v3. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com> Change-Id: I44b1f276b8ef3c4a1a456b402ba8f53d8c870803
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16131
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 984465d with merge base 488d761 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This PR does not implement general broadcasting semantics, but rather adds support for a very specific broadcasting case required for MobileNet v3 (MV3). |
|
My two cents is that full broadcasting support takes engineering effort, code size, and likely performance tradeoffs, and on the other hand the selection of networks which makes sense to run on MCUs is fairly limited and might not use a lot of broadcasting. So in my view only implementing what is used makes sense here, until we see a large need for full broadcasting support (if ever). |
Seems reasonable, if more usecases / models start requiring general broadcasting, we could look at supporting it more broadly |
…16131) Adds support for broadcasting in the special case where one input contains only channels which are broadcasted onto every spatial element of the other tensor, e.g. [1,C,1,1] + [N, C, H, W] for channel-last tensors. This is a needed for mobilenet_v3. Signed-off-by: Adrian Lundell <adrian.lundell@arm.com>
Adds support for broadcasting in the special case where one input contains only channels which are broadcasted onto every spatial element of the other tensor, e.g. [1,C,1,1] + [N, C, H, W] for channel-last tensors.
This is a needed for mobilenet_v3.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai