[OpenVINO] Fix Quantizer for PTQ #15891

anzr299 · 2025-11-19T14:54:04Z

Summary

PTQ in OpenVINO quantizer was causing errors which are fixed in this PR.

cc @kimishpatel @jerryzh168 @digantdesai

pytorch-bot · 2025-11-19T14:54:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15891

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2d8919f with merge base 7fa93a7 ():

NEW FAILURE - The following job has failed:

pull / unittest-editable / macos / macos-job (gh)
backends/xnnpack/test/ops/test_conv2d.py::TestConv2d::test_fp16_conv2d

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla · 2025-11-19T14:54:10Z

Hi @anzr299!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

github-actions · 2025-11-19T14:55:27Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

This PR fixes critical bugs in the OpenVINO quantizer's Post-Training Quantization (PTQ) implementation. The changes simplify the MinMaxQuantization initialization by delegating configuration to the caller via kwargs, and fix a critical bug where a missing return statement would have caused _get_edge_or_node to return None.

Key Changes:

Simplified MinMaxQuantization initialization by removing preset/model_type logic
Fixed missing return statement in _get_edge_or_node method for weight quantization
Refactored weight compression mode string handling

Comments suppressed due to low confidence (2)

backends/openvino/quantizer/quantizer.py:23

Import of 'nncf_logger' is not used.

from nncf.common.logging import nncf_logger  # type: ignore[import-untyped]

backends/openvino/quantizer/quantizer.py:35

Import of 'get_weight_tensor_port_ids' is not used.

from nncf.torch.model_graph_manager import (  # type: ignore[import-untyped]
    get_weight_tensor_port_ids,
)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

backends/openvino/quantizer/quantizer.py

…9/executorch into an/openvino/quantizer_fix

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

mergennachin · 2025-12-02T16:41:13Z

There are some lint errors. Please run this command locally:

https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

suryasidd · 2025-12-02T20:10:58Z

There are some lint errors. Please run this command locally:

https://github.com/pytorch/executorch/blob/main/CONTRIBUTING.md#lintrunner

Hey @mergennachin, Fixed the lint issues. All tests seem to be passing now expect for the one failure not related to this PR

anzr299 added 2 commits November 19, 2025 18:46

init

73ef0ce

minor WC fix

ce84091

fix

91830a7

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2025

anzr299 marked this pull request as ready for review November 21, 2025 14:30

Copilot AI review requested due to automatic review settings November 21, 2025 14:30

Merge branch 'main' into an/openvino/quantizer_fix

c9b7ba4

Copilot started reviewing on behalf of anzr299 November 21, 2025 14:30 View session

Copilot finished reviewing on behalf of anzr299 November 21, 2025 14:32

Copilot AI reviewed Nov 21, 2025

View reviewed changes

backends/openvino/quantizer/quantizer.py Outdated Show resolved Hide resolved

backends/openvino/quantizer/quantizer.py Show resolved Hide resolved

anzr299 added 3 commits November 24, 2025 20:31

review changes

0b7cad6

Merge branch 'an/openvino/quantizer_fix' of https://github.com/anzr29…

3ec3e1e

…9/executorch into an/openvino/quantizer_fix

Merge branch 'pytorch:main' into an/openvino/quantizer_fix

a4c27fe

Copilot AI review requested due to automatic review settings November 24, 2025 16:37

Copilot started reviewing on behalf of anzr299 November 24, 2025 16:37 View session

Copilot finished reviewing on behalf of anzr299 November 24, 2025 16:40

Copilot AI reviewed Nov 24, 2025

View reviewed changes

anzr299 added 3 commits November 25, 2025 14:31

Merge branch 'main' into an/openvino/quantizer_fix

33219ba

revert minmax algo initialization

d3c02e3

clean

82e383d

Copilot AI review requested due to automatic review settings November 27, 2025 15:14

Copilot AI reviewed Nov 27, 2025

View reviewed changes

mergennachin self-requested a review December 1, 2025 16:27

mergennachin approved these changes Dec 1, 2025

View reviewed changes

Merge branch 'main' into an/openvino/quantizer_fix

5973993

Copilot AI review requested due to automatic review settings December 1, 2025 20:29

Copilot started reviewing on behalf of anzr299 December 1, 2025 20:29 View session

Copilot finished reviewing on behalf of anzr299 December 1, 2025 20:30

Copilot AI reviewed Dec 1, 2025

View reviewed changes

Merge branch 'pytorch:main' into an/openvino/quantizer_fix

40e6030

Fixed linter issues

43f4b1f

Copilot AI review requested due to automatic review settings December 2, 2025 17:44

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Merge branch 'main' into an/openvino/quantizer_fix

2d8919f

mergennachin merged commit 4ef35e0 into pytorch:main Dec 3, 2025
140 of 141 checks passed

jirioc pushed a commit to nxp-upstream/executorch that referenced this pull request Dec 19, 2025

[OpenVINO] Fix Quantizer for PTQ (pytorch#15891)

12d2b2f

nil-is-all added module: quantization Issues related to quantization module: openvino Issues and PRs related to backends/openvino labels Jan 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OpenVINO] Fix Quantizer for PTQ #15891

[OpenVINO] Fix Quantizer for PTQ #15891

Uh oh!

anzr299 commented Nov 19, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

meta-cla bot commented Nov 19, 2025

Uh oh!

github-actions bot commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

mergennachin commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

suryasidd commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[OpenVINO] Fix Quantizer for PTQ #15891

[OpenVINO] Fix Quantizer for PTQ #15891

Uh oh!

Conversation

anzr299 commented Nov 19, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

pytorch-bot bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15891

❌ 1 New Failure

Uh oh!

meta-cla bot commented Nov 19, 2025

Action Required

Process

Uh oh!

github-actions bot commented Nov 19, 2025

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mergennachin commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

suryasidd commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anzr299 commented Nov 19, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Nov 19, 2025 •

edited

Loading

This PR needs a `release notes:` label